Toolbox |
---|
This peer review discussion has been closed.
Dan Leno, the leading English music hall comedian and Victorian stage actor was a popular music hall performer and was chiefly known for his many dame pantomime roles that were popular at London's Theatre Royal, Drury Lane, from 1888 to 1904. During his career, he originated and popularised many songs in his music hall act; some of which were recorded and released to the general public. A few months ago, I significantly contributed to the main article and co-nominated it at
FAC, and it was promoted to FA status. As I went along, I extensively researched his recordings and songs and have compiled this short list which now supports the main article. I feel confident that this list is a thorough and comprehensive collection of Leno's works and now, together with
Ssilvers, we intend to submit it to
WP:FLC for consideration. Before doing so however, we are submitting it for this peer review in the hope that we gain some knowledge about FLC before it's listing. We hope that you enjoy reading this article and look forward to all comments and suggestions. Thanks --
Cassianto
Talk
18:26, 26 June 2012 (UTC)
"The tables do not meet WP:ACCESS, see also WP:DTT."
"The other is that this article lists his songs"
I've had a look at the table to see how well it meets the accessibility guidelines of WP:DTAB. To be frank, you've done the most important part by identifying and marking up the column headers with ! scope="col", so that's a good start. The reason for the extra markup is because some visually-impaired visitors use a screen reader that allows then to navigate around a table in any direction. They may want to read down the column of notes in the second table, for example. What the extra markup does is to identify for each cell a column header and a row header that can be announced by the screen reader in conjunction with that cell. For example when they reach 11th row of 3rd column of the second table, then instead of just hearing "Written by Leno", they could hear something like "I'll Be Waiting For Him Tonight", "Notes", "Written by Leno" - I hope you would agree that would be much better for them. For that to happen, we have to use not only ! scope="col" for the column headers, but also we have to choose and to mark up the row headers (I'd suggest the titles are best for this) with the markup ! scope="row". That also alters the formatting of those cells making them bold and centred (i.e. headers), so we often return them to normal weight and left-aligned by using the class "plainrowheaders" in the first line of the wikitable. I've sandboxed examples of how you might mark up the two tables at User:RexxS/The music of Dan Leno - have a look at the edit mode to see the wiki-markup of course. Please feel free to take/use any part of what I've done there, or ask me to show you any changes you want to the formatting - as you can see I've left-aligned the notes to fit in with the left-aligned titles, but you can have centred text if you prefer it (I prefer the left-aligned, but that's merely a personal preference). Does that make sense? I'd be happy to go over it step-by-step if you wish, or you could compare what I'm suggesting here with this edit and the two subsequent ones on List of space stations which added the row headers to a table there. Let me know if I can help any further, and good luck with the FLC. Ping me for a review when you get there at least. -- RexxS ( talk) 23:16, 1 July 2012 (UTC)
Toolbox |
---|
This peer review discussion has been closed.
Dan Leno, the leading English music hall comedian and Victorian stage actor was a popular music hall performer and was chiefly known for his many dame pantomime roles that were popular at London's Theatre Royal, Drury Lane, from 1888 to 1904. During his career, he originated and popularised many songs in his music hall act; some of which were recorded and released to the general public. A few months ago, I significantly contributed to the main article and co-nominated it at
FAC, and it was promoted to FA status. As I went along, I extensively researched his recordings and songs and have compiled this short list which now supports the main article. I feel confident that this list is a thorough and comprehensive collection of Leno's works and now, together with
Ssilvers, we intend to submit it to
WP:FLC for consideration. Before doing so however, we are submitting it for this peer review in the hope that we gain some knowledge about FLC before it's listing. We hope that you enjoy reading this article and look forward to all comments and suggestions. Thanks --
Cassianto
Talk
18:26, 26 June 2012 (UTC)
"The tables do not meet WP:ACCESS, see also WP:DTT."
"The other is that this article lists his songs"
I've had a look at the table to see how well it meets the accessibility guidelines of WP:DTAB. To be frank, you've done the most important part by identifying and marking up the column headers with ! scope="col", so that's a good start. The reason for the extra markup is because some visually-impaired visitors use a screen reader that allows then to navigate around a table in any direction. They may want to read down the column of notes in the second table, for example. What the extra markup does is to identify for each cell a column header and a row header that can be announced by the screen reader in conjunction with that cell. For example when they reach 11th row of 3rd column of the second table, then instead of just hearing "Written by Leno", they could hear something like "I'll Be Waiting For Him Tonight", "Notes", "Written by Leno" - I hope you would agree that would be much better for them. For that to happen, we have to use not only ! scope="col" for the column headers, but also we have to choose and to mark up the row headers (I'd suggest the titles are best for this) with the markup ! scope="row". That also alters the formatting of those cells making them bold and centred (i.e. headers), so we often return them to normal weight and left-aligned by using the class "plainrowheaders" in the first line of the wikitable. I've sandboxed examples of how you might mark up the two tables at User:RexxS/The music of Dan Leno - have a look at the edit mode to see the wiki-markup of course. Please feel free to take/use any part of what I've done there, or ask me to show you any changes you want to the formatting - as you can see I've left-aligned the notes to fit in with the left-aligned titles, but you can have centred text if you prefer it (I prefer the left-aligned, but that's merely a personal preference). Does that make sense? I'd be happy to go over it step-by-step if you wish, or you could compare what I'm suggesting here with this edit and the two subsequent ones on List of space stations which added the row headers to a table there. Let me know if I can help any further, and good luck with the FLC. Ping me for a review when you get there at least. -- RexxS ( talk) 23:16, 1 July 2012 (UTC)