![]() | This is an archive of past discussions. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
Archive 1 | Archive 2 | Archive 3 | Archive 4 | Archive 5 | Archive 6 | → | Archive 10 |
I'm continuing work on author-handling. Having good examples to work from will help me handle tricky and special cases. If you have citations that have been problematic in the past or which you think would make good test cases, please either drop a link to the diff + line number here or copy the to-be-fixed citation to the sandbox I've been using on testwiki: User:Fhocutt (WMF)/Sandbox. Thank you all for the input and suggestions so far, and any resources you can offer here. -- Fhocutt (WMF) ( talk) 21:42, 15 September 2015 (UTC)
Thank you! I've added the examples above to my testwiki sandbox.
Please test the tool now. It should not modify authors when author name-related parameters exist, including the new vauthors. However, it should fetch and expand author data when available if there are no existing parameters. You can help by reporting bugs here or at https://phabricator.wikimedia.org/T111891.
Known issues:
It should convert curved quotes to "'" in fetched author data, but I don't have any references to serve as a test case for this. If you do, please leave them here or in my testwiki sandbox. -- Fhocutt (WMF) ( talk) 01:03, 18 September 2015 (UTC)
This is a good candidate for starting to add automated tests to the bot's codebase. You can help by commenting here or on the Phabricator task with examples of citations with strange formatting and edge cases--spaces in strange places, multiline parameters or values, and similar. The idea here is to have a better way to make sure that the bot continues to parse template parameters and values correctly, even when changes are made to the code. Your help is appreciated. --
Fhocutt (WMF) (
talk)
03:41, 3 October 2015 (UTC)
{{ notabug}}
That's probably because these refs were inside {{
PBB_Summary}} template. Some user already filed them.--
RoadTrain (
talk)
22:02, 31 May 2016 (UTC)
|author=
, the bot adds |last2=
, |last3=
, |last4=
, ... without the corresponding |first2=
, |first3=
, |first4=
, ...|author=
contains the full author list, then the bot should not add |last2=
, |last3=
, |last4=
, ... parameters|author=
contains a complete author list, do not unnecessarily add |last2=
, |last3=
, |last4=
, ...
Extended content
|
---|
This is essentially the same bug that was previously reported here but it still occurring. Boghog ( talk) 19:48, 25 October 2014 (UTC)
I believe that the bug described here is a duplicate of one described above. I have found that e-mailing the bot's maintainer is more effective than posting here at eliciting a response to requests perceived as urgent. In the meantime, the undo link is always available to you, and there are instructions for blocking the bot from specific articles displayed on the bot's user page. – Jonesey95 ( talk) 00:01, 28 October 2014 (UTC)
Workaround based on {{ vcite2 journal}}As a follow-up to the above discussion, a new {{
vcite2 journal}} template with an optional
|
Extended content
| ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@ Boghog, Materialscientist, and Ryan Kaldari (WMF): I've been looking into the way the bot handles and expands multiple authors. The main issues seem to come from an odd choice to reassign several parameters (including authors and coauthor(s)) to author2, which I have temporarily fixed. There are also some hiccups when expanding "et al."--for some formattings of author lists, the list of names is not recognized as a list, so it thinks the list is a single author and fetches the rest of the author names because it looks like there are missing parameters. My questions:
|
Flagging as {{ notabug}}, since it seems to be resolved now and is no longer doing this. AManWithNoPlan ( talk) 15:42, 9 August 2016 (UTC)
The main page lists two repositories, and a google search finds others from other peoples for unknown reasons (We can call those suppositories instead of repositories). Both repositories seem to have been updated in the last year. AManWithNoPlan ( talk) 18:23, 12 August 2016 (UTC)
{{ notabug}}
The bot should add "displayeditors=29" if there are exactly four editors to avoid the Lua error described for exactly 9 authors above. –
Jonesey95 (
talk) 23:49, 21 September 2013 (UTC)
Is this still a bug?
AManWithNoPlan (
talk)
20:43, 6 August 2016 (UTC)
"editor4", "editor4-author", "editor4-first", "editor4-link",
add these lines
"editor5", "editor5-author", "editor5-first", "editor5-link",
"editor6", "editor6-author", "editor6-first", "editor6-link",
"editor7", "editor7-author", "editor7-first", "editor7-link",
"editor8", "editor8-author", "editor8-first", "editor8-link",
"editor9", "editor9-author", "editor9-first", "editor9-link",
"editor10", "editor10-author", "editor10-first", "editor10-link",
"editor11", "editor11-author", "editor11-first", "editor11-link",
"editor12", "editor12-author", "editor12-first", "editor12-link",
"editor13", "editor13-author", "editor13-first", "editor13-link",
"editor14", "editor14-author", "editor14-first", "editor14-link",
and so on AManWithNoPlan ( talk) 03:54, 7 August 2016 (UTC)
{{ resolved}} It is fixed for long time AManWithNoPlan ( talk) 15:36, 12 October 2016 (UTC)
|DUPLICATE_page=
causes
Module:Citation/CS1 to display a redundant error message|page=
and |pages=
, the bot should do nothing
Extended content
|
---|
Without
with
— Trappist the monk ( talk) 12:11, 26 June 2016 (UTC)
|
{{ notabug}} AManWithNoPlan ( talk) 15:31, 12 October 2016 (UTC)
This Citation_bot is duplicating the parameter "journal=" in a {cite journal} which contains comment-code "<!--xxx-->" as inserting text, "|# # # citation bot : comment placeholder 0 # # #journal =" (as text generated inside the {cite_journal} parameters). This bug had been reported 6 months prior (botching the same page), on 5 February 2016, see:
dif5594. -
Wikid77 (
talk) 22:20, revised
22:36, 2 August 2016 (UTC)
This is all coming from this code AManWithNoPlan ( talk) 19:56, 7 August 2016 (UTC):
class Comment extends Item {
const placeholder_text = '# # # Citation bot : comment placeholder %s # # #';
const regexp = '~<!--.*-->~us';
const treat_identical_separately = FALSE;
public function parse_text($text) {
$this->rawtext = $text;
}
public function parsed_text() {
return $this->rawtext;
}
}
Note that the CASE of the above text does not match the bot bug. The code that fails is in objects.php AManWithNoPlan ( talk) 20:13, 7 August 2016 (UTC):
protected function replace_object ($objects) {
$i = count($objects);
if ($objects) foreach (array_reverse($objects) as $obj)
$this->text = str_replace(sprintf($obj::placeholder_text, --$i), $obj->parsed_text(), $this->text);
}
Note that the replace is CASE SENSITIVE. What about those situations, like in this bug where stuff was changed by Title Case or what not. Then this fails. The solution is:
protected function replace_object ($objects) {
$i = count($objects);
if ($objects) foreach (array_reverse($objects) as $obj)
$this->text = str_ireplace(sprintf($obj::placeholder_text, --$i), $obj->parsed_text(), $this->text);
}
Also should in public function write() in objects.php to add after this code:
if ($my_page->lastrevid != $this->lastrevid) {
echo "\n ! Possible edit conflict detected. Aborting.";
return FALSE;
}
add this code
if ( stripos($this->text,"Citation bot : comment placeholder") != false ) {
echo "\n ! Comment placeholder left escaped. Aborting.";
return FALSE;
}
This will make sure that we never have the bug again. Of course, the bot will fail to work on such pages, so the real solution is to make sure that every escaping is un-escaped. AManWithNoPlan ( talk) 03:45, 7 August 2016 (UTC)
{{ Resolved}} AManWithNoPlan ( talk) 14:35, 12 October 2016 (UTC)
Google has date as "2009.11". The bot changes dots to dashes, which is an improvement over what google gives it. This is vaguely a minor version of the google books data is rubbish bug.
AManWithNoPlan (
talk)
03:14, 19 August 2016 (UTC)
{{ resolved}} It seems to do the right thing now. AManWithNoPlan ( talk) 15:33, 12 October 2016 (UTC)
This bot should be STOPPED until it can be fixed, as it still adds unneeded "DUPLICATE_title" (etc.) even though there is the " Category:Pages using duplicate arguments in template calls" (in cites, infoboxes), and still treats lone parameters as if duplicate when cite contains an HTML comment "<!-- -->" with no duplicate keywords. Meanwhile, the flooding of cite categories hides other pages with real overlooked cite errors, such as vandalism to cite parameters, tracked in category:
Because of the flooding of that unsupported-parameter category by Citation_bot, it took 5 days to fix a vandalized cite page (among 120 listed), which could encourage vandals to hack more pages which can remain botched for 5 days. A flooded category often can prolong errors for months/years in semi-major pages (re: " The Band Perry" listed down under "T"), because cite errors are mainly fixed by wp:wikignomes clearing all pages from a cite-error category, where typical editors almost never fix 90% of red-error cite problems. Stop Citation_bot. - Wikid77 ( talk) 14:58, 30 September 2016 (UTC)
Thanks, Jonesey95, for helping to fix those hundreds of pages in the unsupported category. Because it then contained only 19 pages, I was able to fix the numerous recent hack edits to popular U.S. TV star " Estelle Getty" within 3 hours, after User:Citation_bot had recently linked over 250 pages into that category:
For many editors, fixing those hundreds of pages for parameters "DUPLICATE_xxx" is very tedious because the linked url+titles or dates or publisher must be verified by downloading source pages or PDF documents or googling printed books and scanning for title/date markings to ensure the duplicate is not the original, or in some cases both dates or titles must be fixed, unlike a simple parameter spelling error, such as "tittle=" as "title=" or "frist2=" as "first2=" etc. Hence, the generated cite errors for DUPLICATE_xx are often much harder to fix (and users have complained), plus Citation_bot leaves other duplicate parameters in the same pages and does not solve all the duplication problems, just obscures the unsupported-parameters category by 6x as many pages with complex errors often 10-times harder to fix, as effectively flooding the category by a 60x-heavier workload (when fixed properly). Meanwhile, after fixing several hundred duplicate parameters, I have found almost no vandalism (or other parameter errors) in pages with duplicates, but 1-in-10 misspelled, unsupported parameters seem to be caused by severe hack edits affecting other sections of a page. The largest amount of hacked cites are in unsupported parameters, not in duplicate parameters often caused by a 2nd date in ISO format, a 2nd (sub)title, an alternate URL, a 2nd publisher agency, or a nearby valid author/date also called "title". Citation_bot is obscuring simple fixes by escalating complex duplication issues into the wrong, smaller category. - Wikid77 ( talk) 07:25, 4 October 2016 (UTC)
{{ notabug}} AManWithNoPlan ( talk) 14:35, 12 October 2016 (UTC)
The bot should add "displayeditors=29" if there are exactly four editors to avoid the Lua error described for exactly 9 authors above. –
Jonesey95 (
talk) 23:49, 21 September 2013 (UTC)
Is this still a bug?
AManWithNoPlan (
talk)
20:43, 6 August 2016 (UTC)
"editor4", "editor4-author", "editor4-first", "editor4-link",
add these lines
"editor5", "editor5-author", "editor5-first", "editor5-link",
"editor6", "editor6-author", "editor6-first", "editor6-link",
"editor7", "editor7-author", "editor7-first", "editor7-link",
"editor8", "editor8-author", "editor8-first", "editor8-link",
"editor9", "editor9-author", "editor9-first", "editor9-link",
"editor10", "editor10-author", "editor10-first", "editor10-link",
"editor11", "editor11-author", "editor11-first", "editor11-link",
"editor12", "editor12-author", "editor12-first", "editor12-link",
"editor13", "editor13-author", "editor13-first", "editor13-link",
"editor14", "editor14-author", "editor14-first", "editor14-link",
and so on AManWithNoPlan ( talk) 03:54, 7 August 2016 (UTC)
{{ resolved}} It is fixed for long time AManWithNoPlan ( talk) 15:36, 12 October 2016 (UTC)
|DUPLICATE_page=
causes
Module:Citation/CS1 to display a redundant error message|page=
and |pages=
, the bot should do nothing
Extended content
|
---|
Without
with
— Trappist the monk ( talk) 12:11, 26 June 2016 (UTC)
|
{{ notabug}} AManWithNoPlan ( talk) 15:31, 12 October 2016 (UTC)
This Citation_bot is duplicating the parameter "journal=" in a {cite journal} which contains comment-code "<!--xxx-->" as inserting text, "|# # # citation bot : comment placeholder 0 # # #journal =" (as text generated inside the {cite_journal} parameters). This bug had been reported 6 months prior (botching the same page), on 5 February 2016, see:
dif5594. -
Wikid77 (
talk) 22:20, revised
22:36, 2 August 2016 (UTC)
This is all coming from this code AManWithNoPlan ( talk) 19:56, 7 August 2016 (UTC):
class Comment extends Item {
const placeholder_text = '# # # Citation bot : comment placeholder %s # # #';
const regexp = '~<!--.*-->~us';
const treat_identical_separately = FALSE;
public function parse_text($text) {
$this->rawtext = $text;
}
public function parsed_text() {
return $this->rawtext;
}
}
Note that the CASE of the above text does not match the bot bug. The code that fails is in objects.php AManWithNoPlan ( talk) 20:13, 7 August 2016 (UTC):
protected function replace_object ($objects) {
$i = count($objects);
if ($objects) foreach (array_reverse($objects) as $obj)
$this->text = str_replace(sprintf($obj::placeholder_text, --$i), $obj->parsed_text(), $this->text);
}
Note that the replace is CASE SENSITIVE. What about those situations, like in this bug where stuff was changed by Title Case or what not. Then this fails. The solution is:
protected function replace_object ($objects) {
$i = count($objects);
if ($objects) foreach (array_reverse($objects) as $obj)
$this->text = str_ireplace(sprintf($obj::placeholder_text, --$i), $obj->parsed_text(), $this->text);
}
Also should in public function write() in objects.php to add after this code:
if ($my_page->lastrevid != $this->lastrevid) {
echo "\n ! Possible edit conflict detected. Aborting.";
return FALSE;
}
add this code
if ( stripos($this->text,"Citation bot : comment placeholder") != false ) {
echo "\n ! Comment placeholder left escaped. Aborting.";
return FALSE;
}
This will make sure that we never have the bug again. Of course, the bot will fail to work on such pages, so the real solution is to make sure that every escaping is un-escaped. AManWithNoPlan ( talk) 03:45, 7 August 2016 (UTC)
{{ Resolved}} AManWithNoPlan ( talk) 14:35, 12 October 2016 (UTC)
Google has date as "2009.11". The bot changes dots to dashes, which is an improvement over what google gives it. This is vaguely a minor version of the google books data is rubbish bug.
AManWithNoPlan (
talk)
03:14, 19 August 2016 (UTC)
{{ resolved}} It seems to do the right thing now. AManWithNoPlan ( talk) 15:33, 12 October 2016 (UTC)
This bot should be STOPPED until it can be fixed, as it still adds unneeded "DUPLICATE_title" (etc.) even though there is the " Category:Pages using duplicate arguments in template calls" (in cites, infoboxes), and still treats lone parameters as if duplicate when cite contains an HTML comment "<!-- -->" with no duplicate keywords. Meanwhile, the flooding of cite categories hides other pages with real overlooked cite errors, such as vandalism to cite parameters, tracked in category:
Because of the flooding of that unsupported-parameter category by Citation_bot, it took 5 days to fix a vandalized cite page (among 120 listed), which could encourage vandals to hack more pages which can remain botched for 5 days. A flooded category often can prolong errors for months/years in semi-major pages (re: " The Band Perry" listed down under "T"), because cite errors are mainly fixed by wp:wikignomes clearing all pages from a cite-error category, where typical editors almost never fix 90% of red-error cite problems. Stop Citation_bot. - Wikid77 ( talk) 14:58, 30 September 2016 (UTC)
Thanks, Jonesey95, for helping to fix those hundreds of pages in the unsupported category. Because it then contained only 19 pages, I was able to fix the numerous recent hack edits to popular U.S. TV star " Estelle Getty" within 3 hours, after User:Citation_bot had recently linked over 250 pages into that category:
For many editors, fixing those hundreds of pages for parameters "DUPLICATE_xxx" is very tedious because the linked url+titles or dates or publisher must be verified by downloading source pages or PDF documents or googling printed books and scanning for title/date markings to ensure the duplicate is not the original, or in some cases both dates or titles must be fixed, unlike a simple parameter spelling error, such as "tittle=" as "title=" or "frist2=" as "first2=" etc. Hence, the generated cite errors for DUPLICATE_xx are often much harder to fix (and users have complained), plus Citation_bot leaves other duplicate parameters in the same pages and does not solve all the duplication problems, just obscures the unsupported-parameters category by 6x as many pages with complex errors often 10-times harder to fix, as effectively flooding the category by a 60x-heavier workload (when fixed properly). Meanwhile, after fixing several hundred duplicate parameters, I have found almost no vandalism (or other parameter errors) in pages with duplicates, but 1-in-10 misspelled, unsupported parameters seem to be caused by severe hack edits affecting other sections of a page. The largest amount of hacked cites are in unsupported parameters, not in duplicate parameters often caused by a 2nd date in ISO format, a 2nd (sub)title, an alternate URL, a 2nd publisher agency, or a nearby valid author/date also called "title". Citation_bot is obscuring simple fixes by escalating complex duplication issues into the wrong, smaller category. - Wikid77 ( talk) 07:25, 4 October 2016 (UTC)
{{ notabug}} AManWithNoPlan ( talk) 14:35, 12 October 2016 (UTC)
![]() | This is an archive of past discussions. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
Archive 1 | Archive 2 | Archive 3 | Archive 4 | Archive 5 | Archive 6 | → | Archive 10 |
I'm continuing work on author-handling. Having good examples to work from will help me handle tricky and special cases. If you have citations that have been problematic in the past or which you think would make good test cases, please either drop a link to the diff + line number here or copy the to-be-fixed citation to the sandbox I've been using on testwiki: User:Fhocutt (WMF)/Sandbox. Thank you all for the input and suggestions so far, and any resources you can offer here. -- Fhocutt (WMF) ( talk) 21:42, 15 September 2015 (UTC)
Thank you! I've added the examples above to my testwiki sandbox.
Please test the tool now. It should not modify authors when author name-related parameters exist, including the new vauthors. However, it should fetch and expand author data when available if there are no existing parameters. You can help by reporting bugs here or at https://phabricator.wikimedia.org/T111891.
Known issues:
It should convert curved quotes to "'" in fetched author data, but I don't have any references to serve as a test case for this. If you do, please leave them here or in my testwiki sandbox. -- Fhocutt (WMF) ( talk) 01:03, 18 September 2015 (UTC)
This is a good candidate for starting to add automated tests to the bot's codebase. You can help by commenting here or on the Phabricator task with examples of citations with strange formatting and edge cases--spaces in strange places, multiline parameters or values, and similar. The idea here is to have a better way to make sure that the bot continues to parse template parameters and values correctly, even when changes are made to the code. Your help is appreciated. --
Fhocutt (WMF) (
talk)
03:41, 3 October 2015 (UTC)
{{ notabug}}
That's probably because these refs were inside {{
PBB_Summary}} template. Some user already filed them.--
RoadTrain (
talk)
22:02, 31 May 2016 (UTC)
|author=
, the bot adds |last2=
, |last3=
, |last4=
, ... without the corresponding |first2=
, |first3=
, |first4=
, ...|author=
contains the full author list, then the bot should not add |last2=
, |last3=
, |last4=
, ... parameters|author=
contains a complete author list, do not unnecessarily add |last2=
, |last3=
, |last4=
, ...
Extended content
|
---|
This is essentially the same bug that was previously reported here but it still occurring. Boghog ( talk) 19:48, 25 October 2014 (UTC)
I believe that the bug described here is a duplicate of one described above. I have found that e-mailing the bot's maintainer is more effective than posting here at eliciting a response to requests perceived as urgent. In the meantime, the undo link is always available to you, and there are instructions for blocking the bot from specific articles displayed on the bot's user page. – Jonesey95 ( talk) 00:01, 28 October 2014 (UTC)
Workaround based on {{ vcite2 journal}}As a follow-up to the above discussion, a new {{
vcite2 journal}} template with an optional
|
Extended content
| ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@ Boghog, Materialscientist, and Ryan Kaldari (WMF): I've been looking into the way the bot handles and expands multiple authors. The main issues seem to come from an odd choice to reassign several parameters (including authors and coauthor(s)) to author2, which I have temporarily fixed. There are also some hiccups when expanding "et al."--for some formattings of author lists, the list of names is not recognized as a list, so it thinks the list is a single author and fetches the rest of the author names because it looks like there are missing parameters. My questions:
|
Flagging as {{ notabug}}, since it seems to be resolved now and is no longer doing this. AManWithNoPlan ( talk) 15:42, 9 August 2016 (UTC)
The main page lists two repositories, and a google search finds others from other peoples for unknown reasons (We can call those suppositories instead of repositories). Both repositories seem to have been updated in the last year. AManWithNoPlan ( talk) 18:23, 12 August 2016 (UTC)
{{ notabug}}
The bot should add "displayeditors=29" if there are exactly four editors to avoid the Lua error described for exactly 9 authors above. –
Jonesey95 (
talk) 23:49, 21 September 2013 (UTC)
Is this still a bug?
AManWithNoPlan (
talk)
20:43, 6 August 2016 (UTC)
"editor4", "editor4-author", "editor4-first", "editor4-link",
add these lines
"editor5", "editor5-author", "editor5-first", "editor5-link",
"editor6", "editor6-author", "editor6-first", "editor6-link",
"editor7", "editor7-author", "editor7-first", "editor7-link",
"editor8", "editor8-author", "editor8-first", "editor8-link",
"editor9", "editor9-author", "editor9-first", "editor9-link",
"editor10", "editor10-author", "editor10-first", "editor10-link",
"editor11", "editor11-author", "editor11-first", "editor11-link",
"editor12", "editor12-author", "editor12-first", "editor12-link",
"editor13", "editor13-author", "editor13-first", "editor13-link",
"editor14", "editor14-author", "editor14-first", "editor14-link",
and so on AManWithNoPlan ( talk) 03:54, 7 August 2016 (UTC)
{{ resolved}} It is fixed for long time AManWithNoPlan ( talk) 15:36, 12 October 2016 (UTC)
|DUPLICATE_page=
causes
Module:Citation/CS1 to display a redundant error message|page=
and |pages=
, the bot should do nothing
Extended content
|
---|
Without
with
— Trappist the monk ( talk) 12:11, 26 June 2016 (UTC)
|
{{ notabug}} AManWithNoPlan ( talk) 15:31, 12 October 2016 (UTC)
This Citation_bot is duplicating the parameter "journal=" in a {cite journal} which contains comment-code "<!--xxx-->" as inserting text, "|# # # citation bot : comment placeholder 0 # # #journal =" (as text generated inside the {cite_journal} parameters). This bug had been reported 6 months prior (botching the same page), on 5 February 2016, see:
dif5594. -
Wikid77 (
talk) 22:20, revised
22:36, 2 August 2016 (UTC)
This is all coming from this code AManWithNoPlan ( talk) 19:56, 7 August 2016 (UTC):
class Comment extends Item {
const placeholder_text = '# # # Citation bot : comment placeholder %s # # #';
const regexp = '~<!--.*-->~us';
const treat_identical_separately = FALSE;
public function parse_text($text) {
$this->rawtext = $text;
}
public function parsed_text() {
return $this->rawtext;
}
}
Note that the CASE of the above text does not match the bot bug. The code that fails is in objects.php AManWithNoPlan ( talk) 20:13, 7 August 2016 (UTC):
protected function replace_object ($objects) {
$i = count($objects);
if ($objects) foreach (array_reverse($objects) as $obj)
$this->text = str_replace(sprintf($obj::placeholder_text, --$i), $obj->parsed_text(), $this->text);
}
Note that the replace is CASE SENSITIVE. What about those situations, like in this bug where stuff was changed by Title Case or what not. Then this fails. The solution is:
protected function replace_object ($objects) {
$i = count($objects);
if ($objects) foreach (array_reverse($objects) as $obj)
$this->text = str_ireplace(sprintf($obj::placeholder_text, --$i), $obj->parsed_text(), $this->text);
}
Also should in public function write() in objects.php to add after this code:
if ($my_page->lastrevid != $this->lastrevid) {
echo "\n ! Possible edit conflict detected. Aborting.";
return FALSE;
}
add this code
if ( stripos($this->text,"Citation bot : comment placeholder") != false ) {
echo "\n ! Comment placeholder left escaped. Aborting.";
return FALSE;
}
This will make sure that we never have the bug again. Of course, the bot will fail to work on such pages, so the real solution is to make sure that every escaping is un-escaped. AManWithNoPlan ( talk) 03:45, 7 August 2016 (UTC)
{{ Resolved}} AManWithNoPlan ( talk) 14:35, 12 October 2016 (UTC)
Google has date as "2009.11". The bot changes dots to dashes, which is an improvement over what google gives it. This is vaguely a minor version of the google books data is rubbish bug.
AManWithNoPlan (
talk)
03:14, 19 August 2016 (UTC)
{{ resolved}} It seems to do the right thing now. AManWithNoPlan ( talk) 15:33, 12 October 2016 (UTC)
This bot should be STOPPED until it can be fixed, as it still adds unneeded "DUPLICATE_title" (etc.) even though there is the " Category:Pages using duplicate arguments in template calls" (in cites, infoboxes), and still treats lone parameters as if duplicate when cite contains an HTML comment "<!-- -->" with no duplicate keywords. Meanwhile, the flooding of cite categories hides other pages with real overlooked cite errors, such as vandalism to cite parameters, tracked in category:
Because of the flooding of that unsupported-parameter category by Citation_bot, it took 5 days to fix a vandalized cite page (among 120 listed), which could encourage vandals to hack more pages which can remain botched for 5 days. A flooded category often can prolong errors for months/years in semi-major pages (re: " The Band Perry" listed down under "T"), because cite errors are mainly fixed by wp:wikignomes clearing all pages from a cite-error category, where typical editors almost never fix 90% of red-error cite problems. Stop Citation_bot. - Wikid77 ( talk) 14:58, 30 September 2016 (UTC)
Thanks, Jonesey95, for helping to fix those hundreds of pages in the unsupported category. Because it then contained only 19 pages, I was able to fix the numerous recent hack edits to popular U.S. TV star " Estelle Getty" within 3 hours, after User:Citation_bot had recently linked over 250 pages into that category:
For many editors, fixing those hundreds of pages for parameters "DUPLICATE_xxx" is very tedious because the linked url+titles or dates or publisher must be verified by downloading source pages or PDF documents or googling printed books and scanning for title/date markings to ensure the duplicate is not the original, or in some cases both dates or titles must be fixed, unlike a simple parameter spelling error, such as "tittle=" as "title=" or "frist2=" as "first2=" etc. Hence, the generated cite errors for DUPLICATE_xx are often much harder to fix (and users have complained), plus Citation_bot leaves other duplicate parameters in the same pages and does not solve all the duplication problems, just obscures the unsupported-parameters category by 6x as many pages with complex errors often 10-times harder to fix, as effectively flooding the category by a 60x-heavier workload (when fixed properly). Meanwhile, after fixing several hundred duplicate parameters, I have found almost no vandalism (or other parameter errors) in pages with duplicates, but 1-in-10 misspelled, unsupported parameters seem to be caused by severe hack edits affecting other sections of a page. The largest amount of hacked cites are in unsupported parameters, not in duplicate parameters often caused by a 2nd date in ISO format, a 2nd (sub)title, an alternate URL, a 2nd publisher agency, or a nearby valid author/date also called "title". Citation_bot is obscuring simple fixes by escalating complex duplication issues into the wrong, smaller category. - Wikid77 ( talk) 07:25, 4 October 2016 (UTC)
{{ notabug}} AManWithNoPlan ( talk) 14:35, 12 October 2016 (UTC)
The bot should add "displayeditors=29" if there are exactly four editors to avoid the Lua error described for exactly 9 authors above. –
Jonesey95 (
talk) 23:49, 21 September 2013 (UTC)
Is this still a bug?
AManWithNoPlan (
talk)
20:43, 6 August 2016 (UTC)
"editor4", "editor4-author", "editor4-first", "editor4-link",
add these lines
"editor5", "editor5-author", "editor5-first", "editor5-link",
"editor6", "editor6-author", "editor6-first", "editor6-link",
"editor7", "editor7-author", "editor7-first", "editor7-link",
"editor8", "editor8-author", "editor8-first", "editor8-link",
"editor9", "editor9-author", "editor9-first", "editor9-link",
"editor10", "editor10-author", "editor10-first", "editor10-link",
"editor11", "editor11-author", "editor11-first", "editor11-link",
"editor12", "editor12-author", "editor12-first", "editor12-link",
"editor13", "editor13-author", "editor13-first", "editor13-link",
"editor14", "editor14-author", "editor14-first", "editor14-link",
and so on AManWithNoPlan ( talk) 03:54, 7 August 2016 (UTC)
{{ resolved}} It is fixed for long time AManWithNoPlan ( talk) 15:36, 12 October 2016 (UTC)
|DUPLICATE_page=
causes
Module:Citation/CS1 to display a redundant error message|page=
and |pages=
, the bot should do nothing
Extended content
|
---|
Without
with
— Trappist the monk ( talk) 12:11, 26 June 2016 (UTC)
|
{{ notabug}} AManWithNoPlan ( talk) 15:31, 12 October 2016 (UTC)
This Citation_bot is duplicating the parameter "journal=" in a {cite journal} which contains comment-code "<!--xxx-->" as inserting text, "|# # # citation bot : comment placeholder 0 # # #journal =" (as text generated inside the {cite_journal} parameters). This bug had been reported 6 months prior (botching the same page), on 5 February 2016, see:
dif5594. -
Wikid77 (
talk) 22:20, revised
22:36, 2 August 2016 (UTC)
This is all coming from this code AManWithNoPlan ( talk) 19:56, 7 August 2016 (UTC):
class Comment extends Item {
const placeholder_text = '# # # Citation bot : comment placeholder %s # # #';
const regexp = '~<!--.*-->~us';
const treat_identical_separately = FALSE;
public function parse_text($text) {
$this->rawtext = $text;
}
public function parsed_text() {
return $this->rawtext;
}
}
Note that the CASE of the above text does not match the bot bug. The code that fails is in objects.php AManWithNoPlan ( talk) 20:13, 7 August 2016 (UTC):
protected function replace_object ($objects) {
$i = count($objects);
if ($objects) foreach (array_reverse($objects) as $obj)
$this->text = str_replace(sprintf($obj::placeholder_text, --$i), $obj->parsed_text(), $this->text);
}
Note that the replace is CASE SENSITIVE. What about those situations, like in this bug where stuff was changed by Title Case or what not. Then this fails. The solution is:
protected function replace_object ($objects) {
$i = count($objects);
if ($objects) foreach (array_reverse($objects) as $obj)
$this->text = str_ireplace(sprintf($obj::placeholder_text, --$i), $obj->parsed_text(), $this->text);
}
Also should in public function write() in objects.php to add after this code:
if ($my_page->lastrevid != $this->lastrevid) {
echo "\n ! Possible edit conflict detected. Aborting.";
return FALSE;
}
add this code
if ( stripos($this->text,"Citation bot : comment placeholder") != false ) {
echo "\n ! Comment placeholder left escaped. Aborting.";
return FALSE;
}
This will make sure that we never have the bug again. Of course, the bot will fail to work on such pages, so the real solution is to make sure that every escaping is un-escaped. AManWithNoPlan ( talk) 03:45, 7 August 2016 (UTC)
{{ Resolved}} AManWithNoPlan ( talk) 14:35, 12 October 2016 (UTC)
Google has date as "2009.11". The bot changes dots to dashes, which is an improvement over what google gives it. This is vaguely a minor version of the google books data is rubbish bug.
AManWithNoPlan (
talk)
03:14, 19 August 2016 (UTC)
{{ resolved}} It seems to do the right thing now. AManWithNoPlan ( talk) 15:33, 12 October 2016 (UTC)
This bot should be STOPPED until it can be fixed, as it still adds unneeded "DUPLICATE_title" (etc.) even though there is the " Category:Pages using duplicate arguments in template calls" (in cites, infoboxes), and still treats lone parameters as if duplicate when cite contains an HTML comment "<!-- -->" with no duplicate keywords. Meanwhile, the flooding of cite categories hides other pages with real overlooked cite errors, such as vandalism to cite parameters, tracked in category:
Because of the flooding of that unsupported-parameter category by Citation_bot, it took 5 days to fix a vandalized cite page (among 120 listed), which could encourage vandals to hack more pages which can remain botched for 5 days. A flooded category often can prolong errors for months/years in semi-major pages (re: " The Band Perry" listed down under "T"), because cite errors are mainly fixed by wp:wikignomes clearing all pages from a cite-error category, where typical editors almost never fix 90% of red-error cite problems. Stop Citation_bot. - Wikid77 ( talk) 14:58, 30 September 2016 (UTC)
Thanks, Jonesey95, for helping to fix those hundreds of pages in the unsupported category. Because it then contained only 19 pages, I was able to fix the numerous recent hack edits to popular U.S. TV star " Estelle Getty" within 3 hours, after User:Citation_bot had recently linked over 250 pages into that category:
For many editors, fixing those hundreds of pages for parameters "DUPLICATE_xxx" is very tedious because the linked url+titles or dates or publisher must be verified by downloading source pages or PDF documents or googling printed books and scanning for title/date markings to ensure the duplicate is not the original, or in some cases both dates or titles must be fixed, unlike a simple parameter spelling error, such as "tittle=" as "title=" or "frist2=" as "first2=" etc. Hence, the generated cite errors for DUPLICATE_xx are often much harder to fix (and users have complained), plus Citation_bot leaves other duplicate parameters in the same pages and does not solve all the duplication problems, just obscures the unsupported-parameters category by 6x as many pages with complex errors often 10-times harder to fix, as effectively flooding the category by a 60x-heavier workload (when fixed properly). Meanwhile, after fixing several hundred duplicate parameters, I have found almost no vandalism (or other parameter errors) in pages with duplicates, but 1-in-10 misspelled, unsupported parameters seem to be caused by severe hack edits affecting other sections of a page. The largest amount of hacked cites are in unsupported parameters, not in duplicate parameters often caused by a 2nd date in ISO format, a 2nd (sub)title, an alternate URL, a 2nd publisher agency, or a nearby valid author/date also called "title". Citation_bot is obscuring simple fixes by escalating complex duplication issues into the wrong, smaller category. - Wikid77 ( talk) 07:25, 4 October 2016 (UTC)
{{ notabug}} AManWithNoPlan ( talk) 14:35, 12 October 2016 (UTC)