GA toolbox |
---|
Reviewing |
Article (
|
visual edit |
history) ·
Article talk (
|
history) ·
Watch
Reviewer: Ewdqwdq ( talk · contribs) 17:38, 8 April 2022 (UTC)
Hello Ewdqwdq. Who are you? Your username resembles a password, and your account is only 12 days old. Please confirm you're not a sockpuppet. Timhowardriley ( talk) 21:15, 8 April 2022 (UTC)
I'm very interested in this article. I would like to understand it enough to incorporate binary search trees (BST) into my code library. However, even though I was exposed to BSTs in two courses (Graph Theory and Data Structures), this article is over my head. It's probably technically correct, but it needs to be heavily expanded. For example, I referred back to my Data Structures textbook to realize that BSTs are an extension of binary trees. Well, the first paragraph after the lead should be an explanation of binary trees and how this article extends them. However, it shouldn't read like binary tree because I can't understand that either. Instead, it should fully define in as simple of terms as possible all the jargon. This is not an easy task. This wikipedia article explains the goal: Wikipedia:Make technical articles understandable. I learned from a published author ( http://www.jimchurchphoto.com/JimBio.html) to write at the 8th grade level. I'm also motivated by "Up Goer Five". It's an attempt to explain rocket science at the Elementary school level. See https://www.explainxkcd.com/wiki/index.php/1133:_Up_Goer_Five . Nonetheless, I wish the editors of this article good reviews. Timhowardriley ( talk) 22:13, 8 April 2022 (UTC)
I'm going to focus on the first Good Article criterion:
Because every BST component is an abstract construct, they need to be converted into visuals. (On the other hand, concrete constructs, like the components of bridges, have innate visuals.) The textbook I'm using to justify this review uses a family tree as its BST visual. It uses nouns like "parent" and "child". It also uses tree components like "branch" and "leaf".
Here are the BST components that should be made visual.
Of course, this list needs to be formed into an essay. If each major step had a representative diagram, then that would be better.
Instead of pseudo code, the article should have a functioning implementation. The reader then could copy/paste into a compiler to run. Who could claim that's not good? Here's a start:
// Filename: vertex.h
class VERTEX {
public:
VERTEX(
char *key,
void *record );
char *key;
void *record;
// I'm only guessing C++ supports recursive structures; C does not.
VERTEX *left_child;
VERTEX *right_child;
VERTEX *insert(
char *key,
void *record );
VERTEX *search(
char *key );
}
// Filename: vertex.cpp
#include "vertex.h"
VERTEX::VERTEX(
char *key,
void *record )
{
// Actual code
}
VERTEX *VERTEX::insert(
char *key,
void *record )
{
// Actual code
}
VERTEX *VERTEX::search(
char *key )
{
// Actual code
}
// Filename: binary_search_tree.h
#include "vertex.h"
class BINARY_SEARCH_TREE {
public:
BINARY_SEARCH_TREE( void );
VERTEX *root;
void insert(
char *key,
void *record );
void *search(
char *key );
}
// Filename: binary_search_tree.cpp
#include "binary_search_tree.h"
BINARY_SEARCH_TREE::BINARY_SEARCH_TREE( void )
{
// Actual code
}
void BINARY_SEARCH_TREE::insert( char *key, void *record )
{
// Actual code
}
void *BINARY_SEARCH_TREE::search( char *key )
{
// Actual code
}
// Filename: person.h
class PERSON {
public:
PERSON( char *full_name );
char *full_name;
char *street_address;
char *city;
char *state_code;
char *zip_code;
}
// Filename: person.cpp
#include "person.h"
PERSON::PERSON( char *full_name )
{
// Actual code
}
// Filename: binary_search_tree_driver.cpp
#include <iostream>
#include "binary_search_tree.h"
#include "person.h"
void main( void )
{
BINARY_SEARCH_TREE *binary_search_tree =
new BINARY_SEARCH_TREE();
PERSON *first_person = new PERSON( "First Person" );
binary_search_tree.insert(
first_person->full_name,
first_person );
PERSON *second_person = new PERSON( "Second Person" );
binary_search_tree.insert(
second_person->full_name,
second_person );
PERSON *search_person =
binary_search_tree.search(
"First Person" );
std::cout
<< "Search result = " << search_person->full_name << "\n";
}
# Filename: makefile
all: binary_search_tree_driver
clean:
rm binary_search_tree_driver *.o
binary_search_tree_driver: \
binary_search_tree_driver.cpp \
binary_search_tree.o \
vertex.o
c++ binary_search_tree_driver.cpp \
binary_search_tree.o \
vertex.o \
-o binary_search_tree_driver
binary_search_tree.o: \
binary_search_tree.cpp \
binary_search_tree.h
c++ -c binary_search_tree.cpp
vertex.o: vertex.cpp vertex.h
c++ -c vertex.cpp
Once this foundation is established, then the article's remaining information will resonate. Final assessment: failed. Submitted, Timhowardriley ( talk) 00:12, 11 April 2022 (UTC)
copy-paste, and compile; Wikipedia is WP:NOTREPOSITORY. Your final assessment should be dismissed. WikiLinuz { talk} 🍁 03:00, 11 April 2022 (UTC)
assuming responsibilities. WikiLinuz { talk} 🍁 06:05, 11 April 2022 (UTC)
GA toolbox |
---|
Reviewing |
Article (
|
visual edit |
history) ·
Article talk (
|
history) ·
Watch
Reviewer: Ewdqwdq ( talk · contribs) 17:38, 8 April 2022 (UTC)
Hello Ewdqwdq. Who are you? Your username resembles a password, and your account is only 12 days old. Please confirm you're not a sockpuppet. Timhowardriley ( talk) 21:15, 8 April 2022 (UTC)
I'm very interested in this article. I would like to understand it enough to incorporate binary search trees (BST) into my code library. However, even though I was exposed to BSTs in two courses (Graph Theory and Data Structures), this article is over my head. It's probably technically correct, but it needs to be heavily expanded. For example, I referred back to my Data Structures textbook to realize that BSTs are an extension of binary trees. Well, the first paragraph after the lead should be an explanation of binary trees and how this article extends them. However, it shouldn't read like binary tree because I can't understand that either. Instead, it should fully define in as simple of terms as possible all the jargon. This is not an easy task. This wikipedia article explains the goal: Wikipedia:Make technical articles understandable. I learned from a published author ( http://www.jimchurchphoto.com/JimBio.html) to write at the 8th grade level. I'm also motivated by "Up Goer Five". It's an attempt to explain rocket science at the Elementary school level. See https://www.explainxkcd.com/wiki/index.php/1133:_Up_Goer_Five . Nonetheless, I wish the editors of this article good reviews. Timhowardriley ( talk) 22:13, 8 April 2022 (UTC)
I'm going to focus on the first Good Article criterion:
Because every BST component is an abstract construct, they need to be converted into visuals. (On the other hand, concrete constructs, like the components of bridges, have innate visuals.) The textbook I'm using to justify this review uses a family tree as its BST visual. It uses nouns like "parent" and "child". It also uses tree components like "branch" and "leaf".
Here are the BST components that should be made visual.
Of course, this list needs to be formed into an essay. If each major step had a representative diagram, then that would be better.
Instead of pseudo code, the article should have a functioning implementation. The reader then could copy/paste into a compiler to run. Who could claim that's not good? Here's a start:
// Filename: vertex.h
class VERTEX {
public:
VERTEX(
char *key,
void *record );
char *key;
void *record;
// I'm only guessing C++ supports recursive structures; C does not.
VERTEX *left_child;
VERTEX *right_child;
VERTEX *insert(
char *key,
void *record );
VERTEX *search(
char *key );
}
// Filename: vertex.cpp
#include "vertex.h"
VERTEX::VERTEX(
char *key,
void *record )
{
// Actual code
}
VERTEX *VERTEX::insert(
char *key,
void *record )
{
// Actual code
}
VERTEX *VERTEX::search(
char *key )
{
// Actual code
}
// Filename: binary_search_tree.h
#include "vertex.h"
class BINARY_SEARCH_TREE {
public:
BINARY_SEARCH_TREE( void );
VERTEX *root;
void insert(
char *key,
void *record );
void *search(
char *key );
}
// Filename: binary_search_tree.cpp
#include "binary_search_tree.h"
BINARY_SEARCH_TREE::BINARY_SEARCH_TREE( void )
{
// Actual code
}
void BINARY_SEARCH_TREE::insert( char *key, void *record )
{
// Actual code
}
void *BINARY_SEARCH_TREE::search( char *key )
{
// Actual code
}
// Filename: person.h
class PERSON {
public:
PERSON( char *full_name );
char *full_name;
char *street_address;
char *city;
char *state_code;
char *zip_code;
}
// Filename: person.cpp
#include "person.h"
PERSON::PERSON( char *full_name )
{
// Actual code
}
// Filename: binary_search_tree_driver.cpp
#include <iostream>
#include "binary_search_tree.h"
#include "person.h"
void main( void )
{
BINARY_SEARCH_TREE *binary_search_tree =
new BINARY_SEARCH_TREE();
PERSON *first_person = new PERSON( "First Person" );
binary_search_tree.insert(
first_person->full_name,
first_person );
PERSON *second_person = new PERSON( "Second Person" );
binary_search_tree.insert(
second_person->full_name,
second_person );
PERSON *search_person =
binary_search_tree.search(
"First Person" );
std::cout
<< "Search result = " << search_person->full_name << "\n";
}
# Filename: makefile
all: binary_search_tree_driver
clean:
rm binary_search_tree_driver *.o
binary_search_tree_driver: \
binary_search_tree_driver.cpp \
binary_search_tree.o \
vertex.o
c++ binary_search_tree_driver.cpp \
binary_search_tree.o \
vertex.o \
-o binary_search_tree_driver
binary_search_tree.o: \
binary_search_tree.cpp \
binary_search_tree.h
c++ -c binary_search_tree.cpp
vertex.o: vertex.cpp vertex.h
c++ -c vertex.cpp
Once this foundation is established, then the article's remaining information will resonate. Final assessment: failed. Submitted, Timhowardriley ( talk) 00:12, 11 April 2022 (UTC)
copy-paste, and compile; Wikipedia is WP:NOTREPOSITORY. Your final assessment should be dismissed. WikiLinuz { talk} 🍁 03:00, 11 April 2022 (UTC)
assuming responsibilities. WikiLinuz { talk} 🍁 06:05, 11 April 2022 (UTC)